diff options
| author | Fabio Estevam <fabio.estevam@nxp.com> | 2017-08-31 14:52:05 -0300 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2017-09-05 13:33:17 -0500 |
| commit | 343ce0cdfae16828d18e9228e26dd19ecc3a457f (patch) | |
| tree | dbb677bd7462ef3cffeaef768e6219d90061abf9 /drivers/pci/dwc/pcie-spear13xx.c | |
| parent | 16f73eb02d7e1765ccab3d2018e0bd98eb93d973 (diff) | |
| download | talos-op-linux-343ce0cdfae16828d18e9228e26dd19ecc3a457f.tar.gz talos-op-linux-343ce0cdfae16828d18e9228e26dd19ecc3a457f.zip | |
PCI: spear13xx: Fix platform_get_irq() error handling
platform_get_irq() returns a negative number on failure, so adjust the
logic to detect such condition and propagate the real error value on
failure.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Pratyush Anand <pratyush.anand@gmail.com>
Diffstat (limited to 'drivers/pci/dwc/pcie-spear13xx.c')
| -rw-r--r-- | drivers/pci/dwc/pcie-spear13xx.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pci/dwc/pcie-spear13xx.c b/drivers/pci/dwc/pcie-spear13xx.c index 80897291e0fb..a1882ace3fe4 100644 --- a/drivers/pci/dwc/pcie-spear13xx.c +++ b/drivers/pci/dwc/pcie-spear13xx.c @@ -199,9 +199,9 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie, int ret; pp->irq = platform_get_irq(pdev, 0); - if (!pp->irq) { + if (pp->irq < 0) { dev_err(dev, "failed to get irq\n"); - return -ENODEV; + return pp->irq; } ret = devm_request_irq(dev, pp->irq, spear13xx_pcie_irq_handler, IRQF_SHARED | IRQF_NO_THREAD, |
