diff options
| author | Martin George <marting@netapp.com> | 2019-03-27 09:52:56 +0100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2019-03-28 18:15:02 +0100 |
| commit | cc2278c413c3a06a93c23ee8722e4dd3d621de12 (patch) | |
| tree | 2a1bda1657d5ea2584dc4cd1d503d65ab0cd118b /drivers/nvme | |
| parent | 988aef9e8b0dd46b55ad08b1522429739e26122d (diff) | |
| download | talos-op-linux-cc2278c413c3a06a93c23ee8722e4dd3d621de12.tar.gz talos-op-linux-cc2278c413c3a06a93c23ee8722e4dd3d621de12.zip | |
nvme-multipath: relax ANA state check
When undergoing state transitions I/O might be requeued, hence
we should always call nvme_mpath_set_live() to schedule requeue_work
whenever the nvme device is live, independent on whether the
old state was live or not.
Signed-off-by: Martin George <marting@netapp.com>
Signed-off-by: Gargi Srinivas <sring@netapp.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/multipath.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 2839bb70badf..f0716f6ce41f 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -404,15 +404,12 @@ static inline bool nvme_state_is_live(enum nvme_ana_state state) static void nvme_update_ns_ana_state(struct nvme_ana_group_desc *desc, struct nvme_ns *ns) { - enum nvme_ana_state old; - mutex_lock(&ns->head->lock); - old = ns->ana_state; ns->ana_grpid = le32_to_cpu(desc->grpid); ns->ana_state = desc->state; clear_bit(NVME_NS_ANA_PENDING, &ns->flags); - if (nvme_state_is_live(ns->ana_state) && !nvme_state_is_live(old)) + if (nvme_state_is_live(ns->ana_state)) nvme_mpath_set_live(ns); mutex_unlock(&ns->head->lock); } |
