summaryrefslogtreecommitdiffstats
path: root/drivers/net/phy/phy.c
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2018-11-09 18:35:52 +0100
committerDavid S. Miller <davem@davemloft.net>2018-11-09 20:11:56 -0800
commit695bce8fd8e994999f40ee279e2fa9979cbae87a (patch)
tree7d8aa60f5346b0d95a1f91a5315d3f70954b547c /drivers/net/phy/phy.c
parenta4bec00b2879e3f9ea99411e37632eabd31c5c65 (diff)
downloadtalos-op-linux-695bce8fd8e994999f40ee279e2fa9979cbae87a.tar.gz
talos-op-linux-695bce8fd8e994999f40ee279e2fa9979cbae87a.zip
net: phy: improve struct phy_device member interrupts handling
As a heritage from the very early days of phylib member interrupts is defined as u32 even though it's just a flag whether interrupts are enabled. So we can change it to a bitfield member. In addition change the code dealing with this member in a way that it's clear we're dealing with a bool value. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy.c')
-rw-r--r--drivers/net/phy/phy.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index dd5bff955128..8dac890f32bf 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -115,9 +115,9 @@ static int phy_clear_interrupt(struct phy_device *phydev)
*
* Returns 0 on success or < 0 on error.
*/
-static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts)
+static int phy_config_interrupt(struct phy_device *phydev, bool interrupts)
{
- phydev->interrupts = interrupts;
+ phydev->interrupts = interrupts ? 1 : 0;
if (phydev->drv->config_intr)
return phydev->drv->config_intr(phydev);
OpenPOWER on IntegriCloud