diff options
| author | Joachim Eastwood <manabian@gmail.com> | 2012-11-16 04:47:15 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-11-19 19:01:18 -0500 |
| commit | c867b55eb4831a493631205f2744b2e77ce0983b (patch) | |
| tree | c8d603edb45c8b7e97ce765f908efa5d60f4d76d /drivers/net/ethernet/smsc/smc911x.c | |
| parent | ae4b46e9d7128d2d76e6857fe0b9fc240e8ac695 (diff) | |
| download | talos-op-linux-c867b55eb4831a493631205f2744b2e77ce0983b.tar.gz talos-op-linux-c867b55eb4831a493631205f2744b2e77ce0983b.zip | |
net/ethernet: remove useless is_valid_ether_addr from drivers ndo_open
If ndo_validate_addr is set to the generic eth_validate_addr
function there is no point in calling is_valid_ether_addr
from driver ndo_open if ndo_open is not used elsewhere in
the driver.
With this change is_valid_ether_addr will be called from the
generic eth_validate_addr function. So there should be no change
in the actual behavior.
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/smsc/smc911x.c')
| -rw-r--r-- | drivers/net/ethernet/smsc/smc911x.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 8d15f7a74b45..990f57467a15 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -1400,16 +1400,6 @@ smc911x_open(struct net_device *dev) DBG(SMC_DEBUG_FUNC, "%s: --> %s\n", dev->name, __func__); - /* - * Check that the address is valid. If its not, refuse - * to bring the device up. The user must specify an - * address using ifconfig eth0 hw ether xx:xx:xx:xx:xx:xx - */ - if (!is_valid_ether_addr(dev->dev_addr)) { - PRINTK("%s: no valid ethernet hw addr\n", __func__); - return -EINVAL; - } - /* reset the hardware */ smc911x_reset(dev); |
