diff options
author | Arnd Bergmann <arnd@arndb.de> | 2019-07-12 11:01:21 +0200 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2019-07-15 10:13:41 +0200 |
commit | dfd6f9ad36368b8dbd5f5a2b2f0a4705ae69a323 (patch) | |
tree | f2acd93ea1ccb8d8d20f8ae0234d8a2ce668c7a2 /drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h | |
parent | b80d6a42bdc97bdb6139107d6034222e9843c6e2 (diff) | |
download | talos-op-linux-dfd6f9ad36368b8dbd5f5a2b2f0a4705ae69a323.tar.gz talos-op-linux-dfd6f9ad36368b8dbd5f5a2b2f0a4705ae69a323.zip |
ACPI: fix false-positive -Wuninitialized warning
clang gets confused by an uninitialized variable in what looks
to it like a never executed code path:
arch/x86/kernel/acpi/boot.c:618:13: error: variable 'polarity' is uninitialized when used here [-Werror,-Wuninitialized]
polarity = polarity ? ACPI_ACTIVE_LOW : ACPI_ACTIVE_HIGH;
^~~~~~~~
arch/x86/kernel/acpi/boot.c:606:32: note: initialize the variable 'polarity' to silence this warning
int rc, irq, trigger, polarity;
^
= 0
arch/x86/kernel/acpi/boot.c:617:12: error: variable 'trigger' is uninitialized when used here [-Werror,-Wuninitialized]
trigger = trigger ? ACPI_LEVEL_SENSITIVE : ACPI_EDGE_SENSITIVE;
^~~~~~~
arch/x86/kernel/acpi/boot.c:606:22: note: initialize the variable 'trigger' to silence this warning
int rc, irq, trigger, polarity;
^
= 0
This is unfortunately a design decision in clang and won't be fixed.
Changing the acpi_get_override_irq() macro to an inline function
reliably avoids the issue.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h')
0 files changed, 0 insertions, 0 deletions