summaryrefslogtreecommitdiffstats
path: root/drivers/net/appletalk
diff options
context:
space:
mode:
authorElena Reshetova <elena.reshetova@intel.com>2017-10-20 10:23:36 +0300
committerDavid S. Miller <davem@davemloft.net>2017-10-22 02:22:38 +0100
commitc6d4e63e065e796d2f2734c1e4e13f85f1c1c5e4 (patch)
tree378dcc65e175a716d39e1ca417fcc2906b862233 /drivers/net/appletalk
parenteaf6ab76430881c30695a9195ce37d6b11b04997 (diff)
downloadtalos-op-linux-c6d4e63e065e796d2f2734c1e4e13f85f1c1c5e4.tar.gz
talos-op-linux-c6d4e63e065e796d2f2734c1e4e13f85f1c1c5e4.zip
drivers, net, ethernet: convert mtk_eth.dma_refcnt from atomic_t to refcount_t
atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses basic atomic operations (set, inc, inc_not_zero, dec_and_test, etc.) Such atomic variables should be converted to a newly provided refcount_t type and API that prevents accidental counter overflows and underflows. This is important since overflows and underflows can lead to use-after-free situation and be exploitable. The variable mtk_eth.dma_refcnt is used as pure reference counter. Convert it to refcount_t and fix up the operations. Suggested-by: Kees Cook <keescook@chromium.org> Reviewed-by: David Windsor <dwindsor@gmail.com> Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/appletalk')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud