diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-01-30 15:11:44 +0000 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2018-02-08 23:56:11 +1100 |
| commit | dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5 (patch) | |
| tree | 54e976a81e05f1231af1d3b4ff33dd8340acf0e9 /drivers/misc | |
| parent | 6cc3f91bf69fc8c1719704607474f9b9df56f348 (diff) | |
| download | talos-op-linux-dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5.tar.gz talos-op-linux-dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5.zip | |
ocxl: fix signed comparison with less than zero
Currently the comparison of used < 0 is always false because
uses is a size_t. Fix this by making used a ssize_t type.
Detected by Coccinelle:
drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression
compared with zero: used < 0
Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/ocxl/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index c90c1a578d2f..1287e4430e6b 100644 --- a/drivers/misc/ocxl/file.c +++ b/drivers/misc/ocxl/file.c @@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count, struct ocxl_context *ctx = file->private_data; struct ocxl_kernel_event_header header; ssize_t rc; - size_t used = 0; + ssize_t used = 0; DEFINE_WAIT(event_wait); memset(&header, 0, sizeof(header)); |
