summaryrefslogtreecommitdiffstats
path: root/drivers/gpu
diff options
context:
space:
mode:
authorNicholas Mc Guire <der.herr@hofr.at>2015-01-19 12:38:11 +0100
committerPhilipp Zabel <p.zabel@pengutronix.de>2015-01-27 15:55:49 +0100
commitaf7537d3c8d0f894f6499376a538e8138ef188ee (patch)
tree71266fe3e10ccce64eada236a6d943420ea04b14 /drivers/gpu
parent5159571ceb44eba9bf9f9a34ec625386d421de9c (diff)
downloadtalos-op-linux-af7537d3c8d0f894f6499376a538e8138ef188ee.tar.gz
talos-op-linux-af7537d3c8d0f894f6499376a538e8138ef188ee.zip
gpu: ipu-v3: wait_for_completion_timeout does not return negative status
This fixes up the return value handling and the return type. Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Diffstat (limited to 'drivers/gpu')
-rw-r--r--drivers/gpu/ipu-v3/ipu-dc.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
index 2326c752d89b..508c81d9c344 100644
--- a/drivers/gpu/ipu-v3/ipu-dc.c
+++ b/drivers/gpu/ipu-v3/ipu-dc.c
@@ -267,7 +267,8 @@ static irqreturn_t dc_irq_handler(int irq, void *dev_id)
void ipu_dc_disable_channel(struct ipu_dc *dc)
{
struct ipu_dc_priv *priv = dc->priv;
- int irq, ret;
+ int irq;
+ unsigned long ret;
u32 val;
/* TODO: Handle MEM_FG_SYNC differently from MEM_BG_SYNC */
@@ -282,7 +283,7 @@ void ipu_dc_disable_channel(struct ipu_dc *dc)
enable_irq(irq);
ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50));
disable_irq(irq);
- if (ret <= 0) {
+ if (ret == 0) {
dev_warn(priv->dev, "DC stop timeout after 50 ms\n");
val = readl(dc->base + DC_WR_CH_CONF);
OpenPOWER on IntegriCloud