diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-07-09 23:32:42 +0200 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-08-11 12:04:06 +0200 |
commit | 648a4ce7ca209db92db5c3cecb05c14d147a2e6a (patch) | |
tree | fe45384b1df77ab81746fa4ecf05322f13473594 /drivers/gpu/drm/nouveau/nouveau_ttm.c | |
parent | 141518b64f611536fb7968d291c794d71879099e (diff) | |
download | talos-op-linux-648a4ce7ca209db92db5c3cecb05c14d147a2e6a.tar.gz talos-op-linux-648a4ce7ca209db92db5c3cecb05c14d147a2e6a.zip |
drm/rockchip: Don't grab dev->struct_mutex for in mmap offset ioctl
Since David Herrmann's mmap vma manager rework we don't need to grab
dev->struct_mutex any more to prevent races when looking up the mmap
offset. Drop it and instead don't forget to use the unref_unlocked
variant (since the drm core still cares).
Aside: I stumbled over the mmap handler which directly does a
dma_mmap_attrs. But totally fails to grab a reference on the
underlying object and hence looks like it happily just leaks the ptes
since there's no guarantee the mmap isn't still around when
gem_free_object is called. Which the kerneldoc of dma_mmap_attrs
explicitly forbids.
v2: Fixup compile fail 0-day spotted.
Cc: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'drivers/gpu/drm/nouveau/nouveau_ttm.c')
0 files changed, 0 insertions, 0 deletions