diff options
| author | Steven Price <steven.price@arm.com> | 2019-03-25 17:37:22 +0000 |
|---|---|---|
| committer | Sudeep Holla <sudeep.holla@arm.com> | 2019-04-12 18:11:18 +0100 |
| commit | fa7fe29a645b4da08efe8ff2392898b88f9ded9f (patch) | |
| tree | 34431a66f2a5f38213a1766260f4b144363e02f9 /drivers/firmware | |
| parent | 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b (diff) | |
| download | talos-op-linux-fa7fe29a645b4da08efe8ff2392898b88f9ded9f.tar.gz talos-op-linux-fa7fe29a645b4da08efe8ff2392898b88f9ded9f.zip | |
firmware: arm_scmi: fix of_node leak in scmi_mailbox_check
of_parse_phandle_with_args() requires the caller to call of_node_put() on
the returned args->np pointer. Otherwise the reference count will remain
incremented.
However, in this case, since we don't actually use the returned pointer,
we can simply pass in NULL.
Fixes: aa4f886f3893f ("firmware: arm_scmi: add basic driver infrastructure for SCMI")
Signed-off-by: Steven Price <steven.price@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/arm_scmi/driver.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 8f952f2f1a29..dd967d675c08 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -654,9 +654,7 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo) static int scmi_mailbox_check(struct device_node *np) { - struct of_phandle_args arg; - - return of_parse_phandle_with_args(np, "mboxes", "#mbox-cells", 0, &arg); + return of_parse_phandle_with_args(np, "mboxes", "#mbox-cells", 0, NULL); } static int scmi_mbox_free_channel(int id, void *p, void *data) |
