diff options
| author | Oded Gabbay <oded.gabbay@gmail.com> | 2018-01-29 17:31:40 +0200 |
|---|---|---|
| committer | Oded Gabbay <oded.gabbay@gmail.com> | 2018-01-29 17:31:40 +0200 |
| commit | 4518cd28d81fa4d2872268e4f8f7b35f387642cc (patch) | |
| tree | 3e6b67b06ecefbcdb2b683db940b12dee708b978 /drivers/dma-buf | |
| parent | 128ccceaba8656573b8b0f86d3ab6e38094cc754 (diff) | |
| download | talos-op-linux-4518cd28d81fa4d2872268e4f8f7b35f387642cc.tar.gz talos-op-linux-4518cd28d81fa4d2872268e4f8f7b35f387642cc.zip | |
dma-fence: add comment for WARN_ON in dma_fence_release()
In dma_fence_release() there is a WARN_ON which could be triggered by
several cases of wrong dma-fence usage. This patch adds a comment to
explain two use-cases to help driver developers that use dma-fence
and trigger that WARN_ON to better understand the reasons for it.
v2: change to a more generic, one-liner comment
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Diffstat (limited to 'drivers/dma-buf')
| -rw-r--r-- | drivers/dma-buf/dma-fence.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 5d101c4053e0..4edb9fd3cf47 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -171,6 +171,7 @@ void dma_fence_release(struct kref *kref) trace_dma_fence_destroy(fence); + /* Failed to signal before release, could be a refcounting issue */ WARN_ON(!list_empty(&fence->cb_list)); if (fence->ops->release) |
