summaryrefslogtreecommitdiffstats
path: root/arch/powerpc/xmon
diff options
context:
space:
mode:
authorLaurent Dufour <ldufour@linux.vnet.ibm.com>2015-01-15 18:23:47 +0100
committerMichael Ellerman <mpe@ellerman.id.au>2015-01-19 09:58:16 +1100
commite6eb2eba494d6f99e69ca3c3748cd37a2544ab38 (patch)
tree894e07e80da4e183b144da53b930d95d010778fb /arch/powerpc/xmon
parentec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc (diff)
downloadtalos-op-linux-e6eb2eba494d6f99e69ca3c3748cd37a2544ab38.tar.gz
talos-op-linux-e6eb2eba494d6f99e69ca3c3748cd37a2544ab38.zip
powerpc/xmon: Fix another endiannes issue in RTAS call from xmon
The commit 3b8a3c010969 ("powerpc/pseries: Fix endiannes issue in RTAS call from xmon") was fixing an endianness issue in the call made from xmon to RTAS. However, as Michael Ellerman noticed, this fix was not complete, the token value was not byte swapped. This lead to call an unexpected and most of the time unexisting RTAS function, which is silently ignored by RTAS. This fix addresses this hole. Reported-by: Michael Ellerman <mpe@ellerman.id.au> Cc: stable@vger.kernel.org Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/xmon')
-rw-r--r--arch/powerpc/xmon/xmon.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 5b150f0c5df9..13c6e200b24e 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -337,6 +337,7 @@ static inline void disable_surveillance(void)
args.token = rtas_token("set-indicator");
if (args.token == RTAS_UNKNOWN_SERVICE)
return;
+ args.token = cpu_to_be32(args.token);
args.nargs = cpu_to_be32(3);
args.nret = cpu_to_be32(1);
args.rets = &args.args[3];
OpenPOWER on IntegriCloud