diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-04-09 18:48:31 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2018-04-16 11:53:41 +0100 |
| commit | f3cc330a10493ed5948f7019a78dfa89721858c8 (patch) | |
| tree | 2db91c4bea2cb48b1de572978380f53a8b2e3444 | |
| parent | 2589bd8242d74430b7a91109cfe59f2e2173e1bd (diff) | |
| download | talos-op-linux-f3cc330a10493ed5948f7019a78dfa89721858c8.tar.gz talos-op-linux-f3cc330a10493ed5948f7019a78dfa89721858c8.zip | |
ASoC: intel: cht_bsw_rt5645: Replace GFP_ATOMIC with GFP_KERNEL in snd_cht_mc_probe
snd_cht_mc_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".
Despite never getting called from atomic context,
snd_cht_mc_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/intel/boards/cht_bsw_rt5645.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c index 49ba1a956a06..f5a5ea6a093c 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5645.c +++ b/sound/soc/intel/boards/cht_bsw_rt5645.c @@ -539,7 +539,7 @@ static int snd_cht_mc_probe(struct platform_device *pdev) int ret_val = 0; int i; - drv = devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_ATOMIC); + drv = devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_KERNEL); if (!drv) return -ENOMEM; |
