summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStuart Hayes <stuart_hayes@yahoo.com>2011-03-02 13:42:05 +0100
committerJiri Kosina <jkosina@suse.cz>2011-03-02 13:42:10 +0100
commitdd65c736d1b5312c80c88a64bf521db4959eded5 (patch)
tree102de6385e3d892c7868201556bfa346f7224ec8
parent19f52522c426b50e934d5fbd0bf759058f03cc60 (diff)
downloadtalos-op-linux-dd65c736d1b5312c80c88a64bf521db4959eded5.tar.gz
talos-op-linux-dd65c736d1b5312c80c88a64bf521db4959eded5.zip
dcdbas: force SMI to happen when expected
The dcdbas driver can do an I/O write to cause a SMI to occur. The SMI handler looks at certain registers and memory locations, so the SMI needs to happen immediately. On some systems I/O writes are posted, though, causing the SMI to happen well after the "outb" occurred, which causes random failures. Following the "outb" with an "inb" forces the write to go through even if it is posted. Signed-off-by: Stuart Hayes <stuart_hayes@yahoo.com> Acked-by: Doug Warzecha <douglas_warzecha@dell.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/firmware/dcdbas.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index 69ad529d92fb..ea5ac2dc1233 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -268,8 +268,10 @@ int dcdbas_smi_request(struct smi_cmd *smi_cmd)
}
/* generate SMI */
+ /* inb to force posted write through and make SMI happen now */
asm volatile (
- "outb %b0,%w1"
+ "outb %b0,%w1\n"
+ "inb %w1"
: /* no output args */
: "a" (smi_cmd->command_code),
"d" (smi_cmd->command_address),
OpenPOWER on IntegriCloud