diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-12-10 09:05:32 -0600 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2020-01-02 15:34:26 +0100 |
| commit | 93bdc0eb0b4bb5e7094fd4a95f4a394e4a927e09 (patch) | |
| tree | 8525049ab2c5338f5db6c372ff35164da3e98d21 | |
| parent | 5a1f8f5e5efa8d536d75ab532714ec248dd6da2b (diff) | |
| download | talos-op-linux-93bdc0eb0b4bb5e7094fd4a95f4a394e4a927e09.tar.gz talos-op-linux-93bdc0eb0b4bb5e7094fd4a95f4a394e4a927e09.zip | |
can: tcan4x5x: tcan4x5x_parse_config(): fix inconsistent IS_ERR and PTR_ERR
Fix inconsistent IS_ERR and PTR_ERR in tcan4x5x_parse_config().
The proper pointer to be passed as argument is tcan4x5x->device_wake_gpio.
This bug was detected with the help of Coccinelle.
Fixes: 2de497356955 ("can: tcan45x: Make wake-up GPIO an optional GPIO")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
| -rw-r--r-- | drivers/net/can/m_can/tcan4x5x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index a413e7548546..eacd428e07e9 100644 --- a/drivers/net/can/m_can/tcan4x5x.c +++ b/drivers/net/can/m_can/tcan4x5x.c @@ -387,7 +387,7 @@ static int tcan4x5x_parse_config(struct m_can_classdev *cdev) tcan4x5x->device_wake_gpio = devm_gpiod_get(cdev->dev, "device-wake", GPIOD_OUT_HIGH); if (IS_ERR(tcan4x5x->device_wake_gpio)) { - if (PTR_ERR(tcan4x5x->power) == -EPROBE_DEFER) + if (PTR_ERR(tcan4x5x->device_wake_gpio) == -EPROBE_DEFER) return -EPROBE_DEFER; tcan4x5x_disable_wake(cdev); |
