summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBoris Krasnovskiy <Boris.Krasnovskiy@lairdconnect.com>2019-09-11 08:41:54 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-10-04 14:16:53 +0200
commit87e8dfa6f7ebdb3e2802a606bda44d26054f92a8 (patch)
treed3407d85c9aae277bfac1a79157670477c2b44b3
parenta3bf4d6816556baa9a503c9232eb7e3f018ff8dc (diff)
downloadtalos-op-linux-87e8dfa6f7ebdb3e2802a606bda44d26054f92a8.tar.gz
talos-op-linux-87e8dfa6f7ebdb3e2802a606bda44d26054f92a8.zip
USB: host: ohci-at91: resume: balance the clock start call
There is a clock enable counter run away problem in resume ohci_at91. Code enables clock that was never disabled in case of non wakeup interface. That would make clock unstoppable in future. Use proper alternative to start clocks only if they were stopped before. Signed-off-by: Boris Krasnovskiy <Boris.Krasnovskiy@lairdconnect.com> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Link: https://lore.kernel.org/r/20190911064154.28633-4-nicolas.ferre@microchip.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/host/ohci-at91.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index 85d67fe42d59..513e48397743 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -643,8 +643,8 @@ ohci_hcd_at91_drv_resume(struct device *dev)
if (ohci_at91->wakeup)
disable_irq_wake(hcd->irq);
-
- at91_start_clock(ohci_at91);
+ else
+ at91_start_clock(ohci_at91);
ohci_resume(hcd, false);
OpenPOWER on IntegriCloud