diff options
| author | Dan Carpenter <error27@gmail.com> | 2009-12-28 13:59:46 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-01-17 11:31:38 -0200 |
| commit | 423f5c0d016cd6b65c468d3dcdeeb708ee68074b (patch) | |
| tree | a361aa5107f06b90b8d3105657ac5c088fc668c8 | |
| parent | c42405096bd804c82c7ac9addcbadea7390158e4 (diff) | |
| download | talos-op-linux-423f5c0d016cd6b65c468d3dcdeeb708ee68074b.tar.gz talos-op-linux-423f5c0d016cd6b65c468d3dcdeeb708ee68074b.zip | |
V4L/DVB (13955): cx25821: fix double unlock in medusa_video_init()
medusa_set_videostandard() takes the lock but it always drops it before
returning.
This was found with a static checker and compile tested only. :/
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
| -rw-r--r-- | drivers/staging/cx25821/cx25821-medusa-video.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/staging/cx25821/cx25821-medusa-video.c b/drivers/staging/cx25821/cx25821-medusa-video.c index e4df8134f059..1eb079b3d429 100644 --- a/drivers/staging/cx25821/cx25821-medusa-video.c +++ b/drivers/staging/cx25821/cx25821-medusa-video.c @@ -860,10 +860,8 @@ int medusa_video_init(struct cx25821_dev *dev) ret_val = medusa_set_videostandard(dev); - if (ret_val < 0) { - mutex_unlock(&dev->lock); + if (ret_val < 0) return -EINVAL; - } return 1; } |
