summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Gortmaker <paul.gortmaker@windriver.com>2019-04-13 11:15:18 -0400
committerMark Brown <broonie@kernel.org>2019-05-08 18:06:28 +0900
commit261e90829fe2f0ab8a9e3912da1126abd3224ad7 (patch)
treec33a7ffb72ec8616963a6659d9c80b567e118723
parentc0ffbd64b9dc14d673e393cc5933f3b4a47ab39c (diff)
downloadtalos-op-linux-261e90829fe2f0ab8a9e3912da1126abd3224ad7.tar.gz
talos-op-linux-261e90829fe2f0ab8a9e3912da1126abd3224ad7.zip
ASoC: soc-acpi: fix implicit header use of module.h/export.h
This file is implicitly relying on an instance of including module.h from <linux/acpi.h>. Ideally, header files under include/linux shouldn't be adding includes of other headers, in anticipation of their consumers, but just the headers needed for the header itself to pass parsing with CPP. The module.h is particularly bad in this sense, as it itself does include a whole bunch of other headers, due to the complexity of module support. Here, we make the include explicit, in order to allow the future removal of module.h from linux/acpi.h without causing build breakage. Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/soc-acpi.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c
index 4fb29f0e561e..444ce0602f76 100644
--- a/sound/soc/soc-acpi.c
+++ b/sound/soc/soc-acpi.c
@@ -4,6 +4,8 @@
//
// Copyright (c) 2013-15, Intel Corporation.
+#include <linux/export.h>
+#include <linux/module.h>
#include <sound/soc-acpi.h>
struct snd_soc_acpi_mach *
OpenPOWER on IntegriCloud