diff options
| author | Ismail, Mustafa <mustafa.ismail@intel.com> | 2017-07-14 09:41:30 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-07-27 15:10:21 -0700 |
| commit | 11e6c231c7d009525f3a99cb1c5b9bb2d894f652 (patch) | |
| tree | 89010e1ad6157ad7d264a34e9e760f8ca13ac6cc | |
| parent | 6823b31afd1091dbf66311f7adc6f44fd53ea514 (diff) | |
| download | talos-op-linux-11e6c231c7d009525f3a99cb1c5b9bb2d894f652.tar.gz talos-op-linux-11e6c231c7d009525f3a99cb1c5b9bb2d894f652.zip | |
RDMA/uverbs: Fix the check for port number
commit 5a7a88f1b488e4ee49eb3d5b82612d4d9ffdf2c3 upstream.
The port number is only valid if IB_QP_PORT is set in the mask.
So only check port number if it is valid to prevent modify_qp from
failing due to an invalid port number.
Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Tested-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/infiniband/core/uverbs_cmd.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c index e63f2a13c5e1..f3f9d0b5dce0 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -1931,7 +1931,8 @@ static int modify_qp(struct ib_uverbs_file *file, goto out; } - if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) { + if ((cmd->base.attr_mask & IB_QP_PORT) && + !rdma_is_port_valid(qp->device, cmd->base.port_num)) { ret = -EINVAL; goto release_qp; } |
