summaryrefslogtreecommitdiffstats
path: root/src/occ_405/wof
diff options
context:
space:
mode:
authorWilliam Bryan <wilbryan@us.ibm.com>2017-04-28 09:34:16 -0500
committerWilliam A. Bryan <wilbryan@us.ibm.com>2017-04-28 15:14:00 -0400
commiteb9cdf57261295ee7c4c745acce6e15653bfa857 (patch)
treefdd1c2cd5345ab6dee224cf3b99c80efabf7cc44 /src/occ_405/wof
parent6bc1827d25df20ea4dbb40129897110b2cc251a8 (diff)
downloadtalos-occ-eb9cdf57261295ee7c4c745acce6e15653bfa857.tar.gz
talos-occ-eb9cdf57261295ee7c4c745acce6e15653bfa857.zip
Don't log an error within PGPE callback
Change-Id: I619513860541b7a98664b42894be5b9dd5f7ed30 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/39811 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Andres A. Lugo-Reyes <aalugore@us.ibm.com> Reviewed-by: Christopher J. Cain <cjcain@us.ibm.com> Reviewed-by: Martha Broyles <mbroyles@us.ibm.com> Reviewed-by: William A. Bryan <wilbryan@us.ibm.com>
Diffstat (limited to 'src/occ_405/wof')
-rw-r--r--src/occ_405/wof/wof.c51
1 files changed, 2 insertions, 49 deletions
diff --git a/src/occ_405/wof/wof.c b/src/occ_405/wof/wof.c
index 14b4bab..3050c52 100644
--- a/src/occ_405/wof/wof.c
+++ b/src/occ_405/wof/wof.c
@@ -508,35 +508,7 @@ void copy_vfrt_to_sram( copy_vfrt_to_sram_parms_t * i_parms)
// Confirm Successful scheduling of WOF VFRT task
if(l_gperc != 0)
{
- //Error in scheduling wof_vfrt task
- /* @
- * @errortype
- * @moduleid COPY_VFRT_TO_SRAM
- * @reasoncode GPE_REQUEST_SCHEDULE_FAILURE
- * @userdata1 rc - gpe_request_schedule return code
- * @userdata2 0
- * @userdata4 OCC_NO_EXTENDED_RC
- * @devdesc OCC Failed to schedule a GPE job for wof vfrt
- */
- errlHndl_t l_errl = createErrl(
- COPY_VFRT_TO_SRAM, // modId
- GPE_REQUEST_SCHEDULE_FAILURE, // reasoncode
- OCC_NO_EXTENDED_RC, // Extended reason code
- ERRL_SEV_UNRECOVERABLE, // Severity
- NULL, // Trace Buf
- DEFAULT_TRACE_SIZE, // Trace Size
- l_gperc, // userdata1
- 0 // userdata2
- );
-
- // Callout firmware
- addCalloutToErrl(l_errl,
- ERRL_CALLOUT_TYPE_COMPONENT_ID,
- ERRL_COMPONENT_ID_FIRMWARE,
- ERRL_CALLOUT_PRIORITY_HIGH);
-
- // Commit error log
- commitErrl(&l_errl);
+ // TODO: Cannot create an error log within a callback function. Need to handle.
}
}
@@ -1610,26 +1582,7 @@ void wof_control_callback( void )
{
if( G_wof_control_parms.action == PGPE_ACTION_WOF_OFF )
{
- // Got some other unsuccessful RC. Create error and request reset
- /*
- * @errortype
- * @moduleid WOF_CONTROL_CALLBACK
- * @reasoncode GPE_REQUEST_RC_FAILURE
- * @userdata1 Return code
- * @userdata4 ERC_WOF_CONTROL_ERROR
- * @devdesc Invalid RC from wof control command
- */
- errlHndl_t l_errl = createErrl(
- WOF_CONTROL_CALLBACK,
- GPE_REQUEST_RC_FAILURE,
- ERC_WOF_CONTROL_ERROR,
- ERRL_SEV_PREDICTIVE, // Correct Severity???
- NULL,
- DEFAULT_TRACE_SIZE,
- G_wof_control_parms.msg_cb.rc,
- 0 );
-
- REQUEST_RESET(l_errl);
+ // TODO: Cannot log an error here, so need to figure out what to do.
}
else
{
OpenPOWER on IntegriCloud