diff options
| author | William Bryan <wilbryan@us.ibm.com> | 2017-04-28 09:34:16 -0500 |
|---|---|---|
| committer | William A. Bryan <wilbryan@us.ibm.com> | 2017-04-28 15:14:00 -0400 |
| commit | eb9cdf57261295ee7c4c745acce6e15653bfa857 (patch) | |
| tree | fdd1c2cd5345ab6dee224cf3b99c80efabf7cc44 /src/occ_405/pgpe | |
| parent | 6bc1827d25df20ea4dbb40129897110b2cc251a8 (diff) | |
| download | talos-occ-eb9cdf57261295ee7c4c745acce6e15653bfa857.tar.gz talos-occ-eb9cdf57261295ee7c4c745acce6e15653bfa857.zip | |
Don't log an error within PGPE callback
Change-Id: I619513860541b7a98664b42894be5b9dd5f7ed30
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/39811
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Andres A. Lugo-Reyes <aalugore@us.ibm.com>
Reviewed-by: Christopher J. Cain <cjcain@us.ibm.com>
Reviewed-by: Martha Broyles <mbroyles@us.ibm.com>
Reviewed-by: William A. Bryan <wilbryan@us.ibm.com>
Diffstat (limited to 'src/occ_405/pgpe')
| -rw-r--r-- | src/occ_405/pgpe/pgpe_interface.c | 32 |
1 files changed, 6 insertions, 26 deletions
diff --git a/src/occ_405/pgpe/pgpe_interface.c b/src/occ_405/pgpe/pgpe_interface.c index e664e9d..5dfb830 100644 --- a/src/occ_405/pgpe/pgpe_interface.c +++ b/src/occ_405/pgpe/pgpe_interface.c @@ -62,6 +62,9 @@ GPE_BUFFER(ipcmsg_start_stop_t G_start_suspend_parms); GPE_BUFFER(ipcmsg_wof_control_t G_wof_control_parms); GPE_BUFFER(ipcmsg_wof_vfrt_t G_wof_vfrt_parms); +// Used to track failure of start_suspend callback +int G_ss_pgpe_rc; // pgpe return codes + // Function Specification // @@ -671,38 +674,15 @@ int pgpe_clip_update(void) // End Function Specification void pgpe_start_suspend_callback(void) { - int pgpe_rc; // pgpe return codes - errlHndl_t err = NULL; // Error handler - - pgpe_rc = G_start_suspend_parms.msg_cb.rc; + G_ss_pgpe_rc = G_start_suspend_parms.msg_cb.rc; do { // Confirm Successfull completion of PGPE start suspend task - if(pgpe_rc != PGPE_RC_SUCCESS) + if(G_ss_pgpe_rc != PGPE_RC_SUCCESS) { //Error in scheduling pgpe start suspend task - - /* @ - * @errortype - * @moduleid PGPE_START_SUSPEND_CALLBACK_MOD - * @reasoncode GPE_REQUEST_SCHEDULE_FAILURE - * @userdata1 pgpe_rc - PGPE return code - * @userdata4 OCC_NO_EXTENDED_RC - * @devdesc OCC Failed to schedule a GPE job for start_suspend - */ - err = createErrl( - PGPE_START_SUSPEND_CALLBACK_MOD, // modId - PGPE_FAILURE, // reasoncode - ERC_PGPE_UNSUCCESSFULL, // Extended reason code - ERRL_SEV_UNRECOVERABLE, // Severity - NULL, // Trace Buf - DEFAULT_TRACE_SIZE, // Trace Size - pgpe_rc, // userdata1 - 0 // userdata2 - ); - - REQUEST_RESET(err); //This will add a firmware callout for us + G_proc_pstate_status = PSTATES_FAILED; break; } // task completed successfully |
