path: root/drivers/usb
diff options
authorPeng Fan <>2016-06-15 13:15:46 +0800
committerMarek Vasut <>2016-06-18 00:49:00 +0200
commit1e6fb0e367564d427d7c57fa7b3b972ecb7147a3 (patch)
tree99e1a47e1964d8e87aed04b1de6d15cdd98d4d3e /drivers/usb
parent7839f5f8092762f048076c6c7b010c10f2ee8a0b (diff)
usb: ehci: only shutdown opened controller
If the usb controller is not running, no need to shutdown it, otherwise `usb stop` complains about: "EHCI failed to shut down host controller". To i.MX7D SDB, there are two usb ports, one Host, one OTG. If we only plug one udisk to the Host port and then `usb start`, the OTG controller for OTG port does not run actually. Then, if `usb stop`, the OTG controller for OTG port will also be shutdown, but it is not running. This patch adds a check to only shutdown the running controller. Signed-off-by: Peng Fan <> Cc: Marek Vasut <> Cc: Simon Glass <> Cc: Mateusz Kulikowski <> Cc: Hans de Goede <> Cc: "Stefan Brüns" <> Cc: Stephen Warren <>
Diffstat (limited to 'drivers/usb')
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index fa5d584b82..13aa70d606 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -210,6 +210,9 @@ static int ehci_shutdown(struct ehci_ctrl *ctrl)
return -EINVAL;
cmd = ehci_readl(&ctrl->hcor->or_usbcmd);
+ /* If not run, directly return */
+ if (!(cmd & CMD_RUN))
+ return 0;
cmd &= ~(CMD_PSE | CMD_ASE);
ehci_writel(&ctrl->hcor->or_usbcmd, cmd);
ret = handshake(&ctrl->hcor->or_usbsts, STS_ASS | STS_PSS, 0,
OpenPOWER on IntegriCloud