diff options
| author | Simon Glass <sjg@chromium.org> | 2011-10-15 19:14:09 +0000 |
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2011-10-23 20:19:53 +0200 |
| commit | f8df9d0d1a1f668cfb37c02fa42e5fa10e0eec0f (patch) | |
| tree | c5ffab016b12e9334c2ef8678e9dcabbbfd99baf /drivers/serial | |
| parent | e877fabeb93135c68c6f00f8e0de982dd799620b (diff) | |
| download | talos-obmc-uboot-f8df9d0d1a1f668cfb37c02fa42e5fa10e0eec0f.tar.gz talos-obmc-uboot-f8df9d0d1a1f668cfb37c02fa42e5fa10e0eec0f.zip | |
NS16550: trivial code clean for checkpatch
This removes most checkpatch warnings from the ns16550 driver and its
header.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/serial')
| -rw-r--r-- | drivers/serial/ns16550.c | 37 |
1 files changed, 20 insertions, 17 deletions
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 0174744dfe..056c25d58f 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -17,24 +17,24 @@ UART_FCR_RXSR | \ UART_FCR_TXSR) /* Clear & enable FIFOs */ #ifdef CONFIG_SYS_NS16550_PORT_MAPPED -#define serial_out(x,y) outb(x,(ulong)y) -#define serial_in(y) inb((ulong)y) +#define serial_out(x, y) outb(x, (ulong)y) +#define serial_in(y) inb((ulong)y) #elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE > 0) -#define serial_out(x,y) out_be32(y,x) -#define serial_in(y) in_be32(y) +#define serial_out(x, y) out_be32(y, x) +#define serial_in(y) in_be32(y) #elif defined(CONFIG_SYS_NS16550_MEM32) && (CONFIG_SYS_NS16550_REG_SIZE < 0) -#define serial_out(x,y) out_le32(y,x) -#define serial_in(y) in_le32(y) +#define serial_out(x, y) out_le32(y, x) +#define serial_in(y) in_le32(y) #else -#define serial_out(x,y) writeb(x,y) -#define serial_in(y) readb(y) +#define serial_out(x, y) writeb(x, y) +#define serial_in(y) readb(y) #endif #ifndef CONFIG_SYS_NS16550_IER #define CONFIG_SYS_NS16550_IER 0x00 #endif /* CONFIG_SYS_NS16550_IER */ -void NS16550_init (NS16550_t com_port, int baud_divisor) +void NS16550_init(NS16550_t com_port, int baud_divisor) { serial_out(CONFIG_SYS_NS16550_IER, &com_port->ier); #if defined(CONFIG_OMAP) && !defined(CONFIG_OMAP3_ZOOM2) @@ -52,15 +52,17 @@ void NS16550_init (NS16550_t com_port, int baud_divisor) serial_out(UART_LCRVAL, &com_port->lcr); #if defined(CONFIG_OMAP) && !defined(CONFIG_OMAP3_ZOOM2) #if defined(CONFIG_APTIX) - serial_out(3, &com_port->mdr1); /* /13 mode so Aptix 6MHz can hit 115200 */ + /* /13 mode so Aptix 6MHz can hit 115200 */ + serial_out(3, &com_port->mdr1); #else - serial_out(0, &com_port->mdr1); /* /16 is proper to hit 115200 with 48MHz */ + /* /16 is proper to hit 115200 with 48MHz */ + serial_out(0, &com_port->mdr1); #endif #endif /* CONFIG_OMAP */ } #ifndef CONFIG_NS16550_MIN_FUNCTIONS -void NS16550_reinit (NS16550_t com_port, int baud_divisor) +void NS16550_reinit(NS16550_t com_port, int baud_divisor) { serial_out(CONFIG_SYS_NS16550_IER, &com_port->ier); serial_out(UART_LCR_BKSE | UART_LCRVAL, &com_port->lcr); @@ -76,9 +78,10 @@ void NS16550_reinit (NS16550_t com_port, int baud_divisor) } #endif /* CONFIG_NS16550_MIN_FUNCTIONS */ -void NS16550_putc (NS16550_t com_port, char c) +void NS16550_putc(NS16550_t com_port, char c) { - while ((serial_in(&com_port->lsr) & UART_LSR_THRE) == 0); + while ((serial_in(&com_port->lsr) & UART_LSR_THRE) == 0) + ; serial_out(c, &com_port->thr); /* @@ -92,7 +95,7 @@ void NS16550_putc (NS16550_t com_port, char c) } #ifndef CONFIG_NS16550_MIN_FUNCTIONS -char NS16550_getc (NS16550_t com_port) +char NS16550_getc(NS16550_t com_port) { while ((serial_in(&com_port->lsr) & UART_LSR_DR) == 0) { #ifdef CONFIG_USB_TTY @@ -104,9 +107,9 @@ char NS16550_getc (NS16550_t com_port) return serial_in(&com_port->rbr); } -int NS16550_tstc (NS16550_t com_port) +int NS16550_tstc(NS16550_t com_port) { - return ((serial_in(&com_port->lsr) & UART_LSR_DR) != 0); + return (serial_in(&com_port->lsr) & UART_LSR_DR) != 0; } #endif /* CONFIG_NS16550_MIN_FUNCTIONS */ |
