diff options
| author | Fabio Estevam <fabio.estevam@freescale.com> | 2013-09-17 23:13:10 -0300 |
|---|---|---|
| committer | Stefano Babic <sbabic@denx.de> | 2013-09-20 17:55:37 +0200 |
| commit | fd37f195cacc068ad4c070dd794643fcb25ef21a (patch) | |
| tree | 517c178c74e02b31866618de48d658806fd52f6e /drivers/net/fec_mxc.c | |
| parent | 1d585241264e5bf465e398cde4cc6c4e42c0a27e (diff) | |
| download | talos-obmc-uboot-fd37f195cacc068ad4c070dd794643fcb25ef21a.tar.gz talos-obmc-uboot-fd37f195cacc068ad4c070dd794643fcb25ef21a.zip | |
net: fec_mxc: Fix timeouts during tftp transfer
Performing tftp transfers on mx28 results in random timeouts.
Hector Palacios and Robert Hodaszi analyzed the root cause being related to the
wrong alignment of the 'buff' buffer inside fec_recv().
Benoît Thébaudeau provided an excellent analysis of the alignment bug that is
present on older versions, such as GCC 4.5.4:
http://marc.info/?l=u-boot&m=137942904906131&w=2
Use ALLOC_CACHE_ALIGN_BUFFER() to avoid alignment issues from older GCC
versions.
Reported-by: Hector Palacios <hector.palacios@digi.com>
Tested-by: Oliver Metz <oliver@freetz.org>
Tested-by: Hector Palacios <hector.palacios@digi.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
Tested-by: Marek Vasut <marex@denx.de>
Diffstat (limited to 'drivers/net/fec_mxc.c')
| -rw-r--r-- | drivers/net/fec_mxc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 210ef02df5..107cd6ecc5 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -794,7 +794,7 @@ static int fec_recv(struct eth_device *dev) uint16_t bd_status; uint32_t addr, size, end; int i; - uchar buff[FEC_MAX_PKT_SIZE] __aligned(ARCH_DMA_MINALIGN); + ALLOC_CACHE_ALIGN_BUFFER(uchar, buff, FEC_MAX_PKT_SIZE); /* * Check if any critical events have happened |
