summaryrefslogtreecommitdiffstats
path: root/drivers/dfu/dfu_mmc.c
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2014-06-11 12:48:08 -0600
committerTom Rini <trini@ti.com>2014-08-09 11:16:58 -0400
commit3ee9593fce0b58124e667734d7bc8d44b11a7be2 (patch)
treef47521946be94b9ba599c30abdc85f88916d8ca4 /drivers/dfu/dfu_mmc.c
parent0e285b503c41bb53f6ef962e6f9c942c1ca47cc6 (diff)
downloadtalos-obmc-uboot-3ee9593fce0b58124e667734d7bc8d44b11a7be2.tar.gz
talos-obmc-uboot-3ee9593fce0b58124e667734d7bc8d44b11a7be2.zip
dfu: add write error handling
Fix calls to dfu_write() and dfu_flush() to detect errors in the I/O itself. This could happen due to problems with the storage medium, or simply when trying to write a FAT/ext file that is larger than the buffer dfu_mmc.c maintains for this purpose. Signal the error by switching the DFU state/status. This will be picked up by the DFU client when it sends the next DFU request. Note that errors can't simply be returned from e.g. dnload_request_complete(), since that function has no way to pass errors back to the DFU client; a call to dnload_request_complete() simply means that a USB OUT completed. This error state/status needs to be cleared when the next DFU client connects. While there is a DFU_CLRSTATUS request, no DFU client seems to send this. Hence, clear this when selecting the USB alternate setting on the USB interface. Finally, dfu.c relies on a call to dfu_flush() to clear up the internal state of the write transaction. Now that errors in dfu_write() are detected, dfu_flush() may no longer be called for every transaction. Separate out the cleanup code into a new function, and call it whenever dfu_write() fails, as well as from any call to dfu_flush(). Signed-off-by: Stephen Warren <swarren@nvidia.com>
Diffstat (limited to 'drivers/dfu/dfu_mmc.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud