diff options
| author | Simon Glass <sjg@chromium.org> | 2014-12-23 12:04:51 -0700 |
|---|---|---|
| committer | Tom Rini <trini@ti.com> | 2015-01-16 14:52:52 -0500 |
| commit | 480ca13e74ddec62540079ddeb689cf275b3073f (patch) | |
| tree | a46a1de02e33207faf28238c378523ba60507d2d /arch/arm/lib | |
| parent | a6b541b09022acb6f7c2754100ae26bd44eed1d9 (diff) | |
| download | talos-obmc-uboot-480ca13e74ddec62540079ddeb689cf275b3073f.tar.gz talos-obmc-uboot-480ca13e74ddec62540079ddeb689cf275b3073f.zip | |
arm: Add warnings about using gdata
We need to get rid of this SPL-specific setting of the global_data pointer.
It is already set up in start.S immediately before board_init_f() is called,
and there may be information there that is needed (e.g. pre-reloc malloc
info).
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'arch/arm/lib')
| -rw-r--r-- | arch/arm/lib/spl.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c index dfcc596815..c41850aaee 100644 --- a/arch/arm/lib/spl.c +++ b/arch/arm/lib/spl.c @@ -15,6 +15,11 @@ /* Pointer to as well as the global data structure for SPL */ DECLARE_GLOBAL_DATA_PTR; + +/* + * WARNING: This is going away very soon. Don't use it and don't submit + * pafches that rely on it. The global_data area is set up in crt0.S. + */ gd_t gdata __attribute__ ((section(".data"))); /* @@ -28,7 +33,7 @@ void __weak board_init_f(ulong dummy) /* Clear the BSS. */ memset(__bss_start, 0, __bss_end - __bss_start); - /* Set global data pointer. */ + /* TODO: Remove settings of the global data pointer here */ gd = &gdata; board_init_r(NULL, 0); |
