summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Rini <trini@ti.com>2014-03-04 15:52:35 -0500
committerTom Rini <trini@ti.com>2014-03-07 10:59:06 -0500
commit3775dcd9c4ad9d7f19f2ff14989f5180aaba3d64 (patch)
tree7a074d67c4f00378e500c082eca52d5c9bcb06e0
parent801cec59076b0d5b0b6946a8a7a6cb77b62f3c8f (diff)
downloadtalos-obmc-uboot-3775dcd9c4ad9d7f19f2ff14989f5180aaba3d64.tar.gz
talos-obmc-uboot-3775dcd9c4ad9d7f19f2ff14989f5180aaba3d64.zip
cmd_nvedit: Make 'env import -c' require size parameter
When importing a checksummed area we need to be told how big the area in question is so that we know that will match the size of the area which the checksum is generated against. Reported-by: Pierre AUBERT <p.aubert@staubli.com> Signed-off-by: Tom Rini <trini@ti.com>
-rw-r--r--common/cmd_nvedit.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 5bcc324675..c53601cf74 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -1008,6 +1008,9 @@ static int do_env_import(cmd_tbl_t *cmdtp, int flag,
if (argc == 2) {
size = simple_strtoul(argv[1], NULL, 16);
+ } else if (argc == 1 && chk) {
+ puts("## Error: external checksum format must pass size\n");
+ return CMD_RET_FAILURE;
} else {
char *s = addr;
OpenPOWER on IntegriCloud