diff options
author | Jesper Juhl <jesper.juhl@gmail.com> | 2007-08-04 01:25:26 +0200 |
---|---|---|
committer | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2007-10-14 13:10:20 +0300 |
commit | 0169b49d52400a6035cd0f2ccd08bcba061a1a9b (patch) | |
tree | 534643ffe146db43ece0ce2476c2da919408bce5 /usr | |
parent | 8d2d4011f1398d984819c65043abb559c451a3c8 (diff) | |
download | talos-obmc-linux-0169b49d52400a6035cd0f2ccd08bcba061a1a9b.tar.gz talos-obmc-linux-0169b49d52400a6035cd0f2ccd08bcba061a1a9b.zip |
UBI: don't use array index before testing if it is negative
I can't find anything guaranteeing that 'ubi_num' cannot be <0 in
drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code
even tests for that and errors out if so. Unfortunately the test
for "ubi_num < 0" happens after we've already used 'ubi_num' as
an array index - bad thing to do if it is negative.
This patch moves the test earlier in the function and then moves
the indexing using that variable after the check. A bit safer :-)
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions