diff options
author | Josh Poimboeuf <jpoimboe@redhat.com> | 2017-02-15 12:21:17 -0600 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-02-20 09:49:34 +0100 |
commit | 9f0c18aec620bc9d82268b3cb937568dd07b43ff (patch) | |
tree | 837310f0aafcdbbef02a4ab70269f7100d441ad7 /tools | |
parent | c470abd4fde40ea6a0846a2beab642a578c0b8cd (diff) | |
download | talos-obmc-linux-9f0c18aec620bc9d82268b3cb937568dd07b43ff.tar.gz talos-obmc-linux-9f0c18aec620bc9d82268b3cb937568dd07b43ff.zip |
objtool: Fix CONFIG_STACK_VALIDATION=y warning for out-of-tree modules
When building a CONFIG_STACK_VALIDATION enabled kernel without the
libelf devel package installed, the Makefile prints a warning:
"Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev, libelf-devel or elfutils-libelf-devel"
But when building an out-of-tree module, the warning doesn't show.
Instead it tries to use objtool, and the build fails with:
/bin/sh: ./tools/objtool/objtool: No such file or directory
Make sure the warning and the disabling of objtool occur in all cases,
by moving the CONFIG_STACK_VALIDATION checks outside the 'ifeq
($(KBUILD_EXTMOD),)' block in the Makefile.
Tested-By: Marc MERLIN <marc@merlins.org>
Suggested-by: Jessica Yu <jeyu@redhat.com>
Reported-by: Marc MERLIN <marc@merlins.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: Jessica Yu <jeyu@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michal Marek <mmarek@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 3b27a0c85d70 ("objtool: Detect and warn if libelf is missing and don't break the build")
Link: http://lkml.kernel.org/r/b3088ae4a8698143d4851965793c61fec2135b1f.1487182864.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions