summaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-trace.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2017-07-19 15:02:43 -0300
committerArnaldo Carvalho de Melo <acme@redhat.com>2017-07-20 09:55:52 -0300
commit325f5091b0da5a7d8d190262661af17d75bee262 (patch)
tree0c2d70b430f843f0125459a068e193b4c003f27c /tools/perf/builtin-trace.c
parentd032d79e2dcb56e13678bf2cc7b36957ef827c32 (diff)
downloadtalos-obmc-linux-325f5091b0da5a7d8d190262661af17d75bee262.tar.gz
talos-obmc-linux-325f5091b0da5a7d8d190262661af17d75bee262.zip
perf trace: Ditch __syscall__arg_val() variant, not needed anymore
All callers now can use syscall__arg_val(arg, idx), be it to iterate thru the syscall arguments while taking into account alignment, or to get values for other arguments that affect how the current argument should be formatted (think of fcntl's 'cmd' and 'arg' arguments). Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/n/tip-wm5b156d8kro1r4y3b33eyta@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-trace.c')
-rw-r--r--tools/perf/builtin-trace.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index fc4d33a6aa58..f8b7bfdf4ee7 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1336,20 +1336,15 @@ out:
* variable to read it. Most notably this avoids extended load instructions
* on unaligned addresses
*/
-static unsigned long __syscall_arg__val(unsigned char *args, u8 idx)
+unsigned long syscall_arg__val(struct syscall_arg *arg, u8 idx)
{
unsigned long val;
- unsigned char *p = args + sizeof(unsigned long) * idx;
+ unsigned char *p = arg->args + sizeof(unsigned long) * idx;
memcpy(&val, p, sizeof(val));
return val;
}
-unsigned long syscall_arg__val(struct syscall_arg *arg, u8 idx)
-{
- return __syscall_arg__val(arg->args, idx);
-}
-
static size_t syscall__scnprintf_val(struct syscall *sc, char *bf, size_t size,
struct syscall_arg *arg, unsigned long val)
{
OpenPOWER on IntegriCloud