diff options
author | Jeff Layton <jlayton@redhat.com> | 2014-02-14 07:20:35 -0500 |
---|---|---|
committer | Steve French <smfrench@gmail.com> | 2014-02-14 16:46:15 -0600 |
commit | 5d81de8e8667da7135d3a32a964087c0faf5483f (patch) | |
tree | fe34f19b7ce6a87fc7809175a3119247bafec508 /net/rds | |
parent | 42eacf9e57b65ffa768af72cb7fc86cc6f6af042 (diff) | |
download | talos-obmc-linux-5d81de8e8667da7135d3a32a964087c0faf5483f.tar.gz talos-obmc-linux-5d81de8e8667da7135d3a32a964087c0faf5483f.zip |
cifs: ensure that uncached writes handle unmapped areas correctly
It's possible for userland to pass down an iovec via writev() that has a
bogus user pointer in it. If that happens and we're doing an uncached
write, then we can end up getting less bytes than we expect from the
call to iov_iter_copy_from_user. This is CVE-2014-0069
cifs_iovec_write isn't set up to handle that situation however. It'll
blindly keep chugging through the page array and not filling those pages
with anything useful. Worse yet, we'll later end up with a negative
number in wdata->tailsz, which will confuse the sending routines and
cause an oops at the very least.
Fix this by having the copy phase of cifs_iovec_write stop copying data
in this situation and send the last write as a short one. At the same
time, we want to avoid sending a zero-length write to the server, so
break out of the loop and set rc to -EFAULT if that happens. This also
allows us to handle the case where no address in the iovec is valid.
[Note: Marking this for stable on v3.4+ kernels, but kernels as old as
v2.6.38 may have a similar problem and may need similar fix]
Cc: <stable@vger.kernel.org> # v3.4+
Reviewed-by: Pavel Shilovsky <piastry@etersoft.ru>
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'net/rds')
0 files changed, 0 insertions, 0 deletions