diff options
| author | Guillaume Nault <g.nault@alphalink.fr> | 2016-02-23 13:59:43 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-02-24 23:52:51 -0500 |
| commit | 555d5b70f1597906dc2e31085f5e70b49d03a536 (patch) | |
| tree | 6167393b53a3cece4957cca9e0167af387c573c5 /net/dsa/slave.c | |
| parent | 4fee7dab07bb2c7dfc3369e0f0e28e3fd4fc00c4 (diff) | |
| download | talos-obmc-linux-555d5b70f1597906dc2e31085f5e70b49d03a536.tar.gz talos-obmc-linux-555d5b70f1597906dc2e31085f5e70b49d03a536.zip | |
ppp: clarify parsing of user supplied data in ppp_set_compress()
* Split big conditional statement.
* Check (data.length <= CCP_MAX_OPTION_LENGTH) only once.
* Don't read ccp_option[1] if not initialised.
Reading uninitialised ccp_option[1] was harmless, because this could
only happen when data.length was 0 or 1. So even then, we couldn't pass
the (ccp_option[1] < 2 || ccp_option[1] > data.length) test anyway.
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/slave.c')
0 files changed, 0 insertions, 0 deletions
