diff options
| author | Wanpeng Li <wanpeng.li@linux.intel.com> | 2014-10-31 06:39:32 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2014-11-04 07:17:53 +0100 |
| commit | 804968809c321066cca028d4cbd533a420f964bc (patch) | |
| tree | 16d858a81fb825da306816a3aec0cc73473229c6 /kernel/sched/deadline.c | |
| parent | 308a623a40ce168eb234ea82c2bd13ff85a098d9 (diff) | |
| download | talos-obmc-linux-804968809c321066cca028d4cbd533a420f964bc.tar.gz talos-obmc-linux-804968809c321066cca028d4cbd533a420f964bc.zip | |
sched/deadline: Fix artificial overrun introduced by yield_task_dl()
The yield semantic of deadline class is to reduce remaining runtime to
zero, and then update_curr_dl() will stop it. However, comsumed bandwidth
is reduced from the budget of yield task again even if it has already been
set to zero which leads to artificial overrun. This patch fix it by make
sure we don't steal some more time from the task that yielded in update_curr_dl().
Suggested-by: Juri Lelli <juri.lelli@arm.com>
Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Kirill Tkhai <ktkhai@parallels.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1414708776-124078-2-git-send-email-wanpeng.li@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched/deadline.c')
| -rw-r--r-- | kernel/sched/deadline.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 9d483e862e58..c047a94de273 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -628,7 +628,7 @@ static void update_curr_dl(struct rq *rq) sched_rt_avg_update(rq, delta_exec); - dl_se->runtime -= delta_exec; + dl_se->runtime -= dl_se->dl_yielded ? 0 : delta_exec; if (dl_runtime_exceeded(rq, dl_se)) { __dequeue_task_dl(rq, curr, 0); if (likely(start_dl_timer(dl_se, curr->dl.dl_boosted))) |
