diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-11-08 13:04:43 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-11-09 16:04:20 -0500 |
| commit | acb32ba3dee66d58704caeeb8c6ff95f60efdc66 (patch) | |
| tree | b5c1d6d5575a7b75c7c816e0809690f58401715c /include/net/icmp.h | |
| parent | e56c57d0d3fdbbdf583d3af96bfb803b8dfa713e (diff) | |
| download | talos-obmc-linux-acb32ba3dee66d58704caeeb8c6ff95f60efdc66.tar.gz talos-obmc-linux-acb32ba3dee66d58704caeeb8c6ff95f60efdc66.zip | |
ipv4: reduce percpu needs for icmpmsg mibs
Reading /proc/net/snmp on a machine with a lot of cpus is very expensive
(can be ~88000 us).
This is because ICMPMSG MIB uses 4096 bytes per cpu, and folding values
for all possible cpus can read 16 Mbytes of memory.
ICMP messages are not considered as fast path on a typical server, and
eventually few cpus handle them anyway. We can afford an atomic
operation instead of using percpu data.
This saves 4096 bytes per cpu and per network namespace.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/icmp.h')
| -rw-r--r-- | include/net/icmp.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/net/icmp.h b/include/net/icmp.h index f0698b955b73..75d615649071 100644 --- a/include/net/icmp.h +++ b/include/net/icmp.h @@ -31,8 +31,8 @@ struct icmp_err { extern const struct icmp_err icmp_err_convert[]; #define ICMP_INC_STATS(net, field) SNMP_INC_STATS((net)->mib.icmp_statistics, field) #define ICMP_INC_STATS_BH(net, field) SNMP_INC_STATS_BH((net)->mib.icmp_statistics, field) -#define ICMPMSGOUT_INC_STATS(net, field) SNMP_INC_STATS((net)->mib.icmpmsg_statistics, field+256) -#define ICMPMSGIN_INC_STATS_BH(net, field) SNMP_INC_STATS_BH((net)->mib.icmpmsg_statistics, field) +#define ICMPMSGOUT_INC_STATS(net, field) SNMP_INC_STATS_ATOMIC_LONG((net)->mib.icmpmsg_statistics, field+256) +#define ICMPMSGIN_INC_STATS_BH(net, field) SNMP_INC_STATS_ATOMIC_LONG((net)->mib.icmpmsg_statistics, field) struct dst_entry; struct net_proto_family; |
