diff options
| author | Christoph Hellwig <hch@infradead.org> | 2014-06-06 16:05:15 +1000 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2014-06-06 16:05:15 +1000 |
| commit | 448011e2ab1c44f7990a62649580bde0da5242b5 (patch) | |
| tree | 78fd087d470f28bb67de5165a5471f69a26f352f /fs/xfs/xfs_aops.c | |
| parent | 72208ee060635dfab2b3bd447a95e0f9c419e954 (diff) | |
| download | talos-obmc-linux-448011e2ab1c44f7990a62649580bde0da5242b5.tar.gz talos-obmc-linux-448011e2ab1c44f7990a62649580bde0da5242b5.zip | |
xfs: tone down writepage/releasepage WARN_ONs
I recently ran into the issue fixed by
"xfs: kill buffers over failed write ranges properly"
which spams the log with lots of backtraces. Make debugging any
issues like that easier by using WARN_ON_ONCE in the writeback code.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs/xfs_aops.c')
| -rw-r--r-- | fs/xfs/xfs_aops.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 0479c32c5eb1..ce0c5ca0a8a3 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -975,7 +975,7 @@ xfs_vm_writepage( * Given that we do not allow direct reclaim to call us, we should * never be called while in a filesystem transaction. */ - if (WARN_ON(current->flags & PF_FSTRANS)) + if (WARN_ON_ONCE(current->flags & PF_FSTRANS)) goto redirty; /* Is this page beyond the end of the file? */ @@ -1188,9 +1188,9 @@ xfs_vm_releasepage( xfs_count_page_state(page, &delalloc, &unwritten); - if (WARN_ON(delalloc)) + if (WARN_ON_ONCE(delalloc)) return 0; - if (WARN_ON(unwritten)) + if (WARN_ON_ONCE(unwritten)) return 0; return try_to_free_buffers(page); |
