diff options
| author | David Howells <dhowells@redhat.com> | 2018-05-23 11:51:29 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2018-05-23 11:51:29 +0100 |
| commit | 1588def91d58bf70afe1acf9fc0331fa26e974f4 (patch) | |
| tree | d018c9b539d1c789b4dc8bba4c59226a22433a2d /fs/afs/proc.c | |
| parent | c875c76a061df306ca82b69ba80b8da3ee758c87 (diff) | |
| download | talos-obmc-linux-1588def91d58bf70afe1acf9fc0331fa26e974f4.tar.gz talos-obmc-linux-1588def91d58bf70afe1acf9fc0331fa26e974f4.zip | |
afs: Mark afs_net::ws_cell as __rcu and set using rcu functions
The afs_net::ws_cell member is sometimes used under RCU conditions from
within an seq-readlock. It isn't, however, marked __rcu and it isn't set
using the proper RCU barrier-imposing functions.
Fix this by annotating it with __rcu and using appropriate barriers to
make sure accesses are correctly ordered.
Without this, the code can produce the following warning:
>> fs/afs/proc.c:151:24: sparse: incompatible types in comparison expression (different address spaces)
Fixes: f044c8847bb6 ("afs: Lay the groundwork for supporting network namespaces")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/afs/proc.c')
| -rw-r--r-- | fs/afs/proc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/afs/proc.c b/fs/afs/proc.c index b45ee7576aa8..362f281b1b16 100644 --- a/fs/afs/proc.c +++ b/fs/afs/proc.c @@ -173,7 +173,7 @@ static ssize_t afs_proc_rootcell_read(struct file *file, char __user *buf, if (*_pos > 0) return 0; - if (!net->ws_cell) + if (!rcu_access_pointer(net->ws_cell)) return 0; rcu_read_lock(); |
