summaryrefslogtreecommitdiffstats
path: root/drivers/usb/core/usb.c
diff options
context:
space:
mode:
authorAlan Stern <stern@rowland.harvard.edu>2018-09-10 13:59:59 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-09-20 12:49:12 +0200
commitbd729f9d67aa9a303d8925bb8c4f06af25f407d1 (patch)
treea2e42a2dc0a0c05668c8b6894ec4e1c6d82ffd03 /drivers/usb/core/usb.c
parentc183813fcee44a249339b7c46e1ad271ca1870aa (diff)
downloadtalos-obmc-linux-bd729f9d67aa9a303d8925bb8c4f06af25f407d1.tar.gz
talos-obmc-linux-bd729f9d67aa9a303d8925bb8c4f06af25f407d1.zip
USB: fix error handling in usb_driver_claim_interface()
The syzbot fuzzing project found a use-after-free bug in the USB core. The bug was caused by usbfs not unbinding from an interface when the USB device file was closed, which led another process to attempt the unbind later on, after the private data structure had been deallocated. The reason usbfs did not unbind the interface at the appropriate time was because it thought the interface had never been claimed in the first place. This was caused by the fact that usb_driver_claim_interface() does not clean up properly when device_bind_driver() returns an error. Although the error code gets passed back to the caller, the iface->dev.driver pointer remains set and iface->condition remains equal to USB_INTERFACE_BOUND. This patch adds proper error handling to usb_driver_claim_interface(). Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Reported-by: syzbot+f84aa7209ccec829536f@syzkaller.appspotmail.com CC: <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/core/usb.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud