summaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorQuytelda Kahja <quytelda@tamalin.org>2018-03-06 17:31:41 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-03-08 09:56:15 -0800
commitc92e677b20fa389e9e81e21fa96e4520a5fd0ba5 (patch)
treedb6c293dd00d538c94f26d3b7dadf4cdbb251dc2 /drivers/staging
parentd956a1a9d32cb14673f5f03ef607d84d603a5ed4 (diff)
downloadtalos-obmc-linux-c92e677b20fa389e9e81e21fa96e4520a5fd0ba5.tar.gz
talos-obmc-linux-c92e677b20fa389e9e81e21fa96e4520a5fd0ba5.zip
staging: most: Remove unnecessary usage of BUG_ON().
There is no need for the calls to BUG_ON() in this driver, which are used to check if mbo or mbo->context are NULL; mbo is never NULL, and if mbo->context is NULL it would have already been dereferenced and oopsed before reaching the BUG_ON(). Signed-off-by: Quytelda Kahja <quytelda@tamalin.org> Acked-by: Christian Gromm <christian.gromm@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/most/core.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index 8d311970225e..8f2833526f7f 100644
--- a/drivers/staging/most/core.c
+++ b/drivers/staging/most/core.c
@@ -916,7 +916,6 @@ static void arm_mbo(struct mbo *mbo)
unsigned long flags;
struct most_channel *c;
- BUG_ON((!mbo) || (!mbo->context));
c = mbo->context;
if (c->is_poisoned) {
@@ -1019,8 +1018,6 @@ static void most_write_completion(struct mbo *mbo)
{
struct most_channel *c;
- BUG_ON((!mbo) || (!mbo->context));
-
c = mbo->context;
if (mbo->status == MBO_E_INVAL)
pr_info("WARN: Tx MBO status: invalid\n");
OpenPOWER on IntegriCloud