summaryrefslogtreecommitdiffstats
path: root/drivers/staging/wilc1000
diff options
context:
space:
mode:
authorChaehyun Lim <chaehyun.lim@gmail.com>2016-04-19 09:35:29 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-04-28 22:04:55 -0700
commitfc6138b6cfc0319791ff860aecd06126b0c6e578 (patch)
tree5fea3e6fc52a5c552674ef31a45e3539423c6d56 /drivers/staging/wilc1000
parent14f3b086fc8225f60b0efaafec2a7bca443f8171 (diff)
downloadtalos-obmc-linux-fc6138b6cfc0319791ff860aecd06126b0c6e578.tar.gz
talos-obmc-linux-fc6138b6cfc0319791ff860aecd06126b0c6e578.zip
staging: wilc1000: change handle_set_ip_address's return type to void
When handle_set_ip_address is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/wilc1000')
-rw-r--r--drivers/staging/wilc1000/host_interface.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 70f348ac2143..7fcdbb3b4ddf 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -349,7 +349,7 @@ static void handle_set_operation_mode(struct wilc_vif *vif,
netdev_err(vif->ndev, "Failed to set driver handler\n");
}
-static s32 handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
+static void handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
{
s32 result = 0;
struct wid wid;
@@ -370,12 +370,8 @@ static s32 handle_set_ip_address(struct wilc_vif *vif, u8 *ip_addr, u8 idx)
host_int_get_ipaddress(vif, firmware_ip_addr, idx);
- if (result) {
+ if (result)
netdev_err(vif->ndev, "Failed to set IP address\n");
- return -EINVAL;
- }
-
- return result;
}
static s32 handle_get_ip_address(struct wilc_vif *vif, u8 idx)
OpenPOWER on IntegriCloud