diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-11-14 21:42:46 +0000 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2018-11-14 14:02:33 -0800 |
| commit | 757ec116c9bce4278fa4423039736c832cc63b6f (patch) | |
| tree | 663a89d21ba00dc1a003be334e5e067b9e44936b /drivers/spi | |
| parent | 2a22f1b30cee8d1e104a6c5062a609bedbfd5c39 (diff) | |
| download | talos-obmc-linux-757ec116c9bce4278fa4423039736c832cc63b6f.tar.gz talos-obmc-linux-757ec116c9bce4278fa4423039736c832cc63b6f.zip | |
spi: npcm: fix u32 csgpio being checked for less than zero
The u32 variable csgpio is being checked for an error return
from the call to of_get_named_gpio, however, since this is unsigned
this comparison will always be false. Fix this by making csgpio an
int and fix up the %u format specifiers to %d accordingly.
Detected by CoverityScan, CID#1475476 ("Unsigned compared against 0")
Fixes: 2a22f1b30cee ("spi: npcm: add NPCM PSPI controller driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-npcm-pspi.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/spi/spi-npcm-pspi.c b/drivers/spi/spi-npcm-pspi.c index 51777515c83f..6dae91091143 100644 --- a/drivers/spi/spi-npcm-pspi.c +++ b/drivers/spi/spi-npcm-pspi.c @@ -329,7 +329,7 @@ static int npcm_pspi_probe(struct platform_device *pdev) unsigned long clk_hz; struct device_node *np = pdev->dev.of_node; int num_cs, i; - u32 csgpio; + int csgpio; int irq; int ret; @@ -417,12 +417,12 @@ static int npcm_pspi_probe(struct platform_device *pdev) dev_err(&pdev->dev, "failed to get csgpio#%u\n", i); goto out_disable_clk; } - dev_dbg(&pdev->dev, "csgpio#%u = %u\n", i, csgpio); + dev_dbg(&pdev->dev, "csgpio#%u = %d\n", i, csgpio); ret = devm_gpio_request_one(&pdev->dev, csgpio, GPIOF_OUT_INIT_HIGH, DRIVER_NAME); if (ret < 0) { dev_err(&pdev->dev, - "failed to configure csgpio#%u %u\n" + "failed to configure csgpio#%u %d\n" , i, csgpio); goto out_disable_clk; } |
