summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/virtio_scsi.c
diff options
context:
space:
mode:
authorDaniel Wagner <daniel.wagner@bmw-carit.de>2016-09-13 10:58:50 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2016-09-14 13:19:57 -0400
commite8f814202597e7416f6633793ec947d66b611895 (patch)
treeb8b22fcabe34a9bc90a1c438d86b129e498cbda2 /drivers/scsi/virtio_scsi.c
parentba2f1293e95f071156f5a6660fb2316d4ea15c46 (diff)
downloadtalos-obmc-linux-e8f814202597e7416f6633793ec947d66b611895.tar.gz
talos-obmc-linux-e8f814202597e7416f6633793ec947d66b611895.zip
scsi: virtio_scsi: Use complete() instead complete_all()
There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context waker context virtscsi_tmf() DECLARE_COMPLETION_ONSTACK() virtscsi_kick_cmd() wait_for_completion() virtscsi_complete_free() complete() Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/virtio_scsi.c')
-rw-r--r--drivers/scsi/virtio_scsi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 7dbbb29d24c6..86924ff145ef 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -258,7 +258,7 @@ static void virtscsi_complete_free(struct virtio_scsi *vscsi, void *buf)
struct virtio_scsi_cmd *cmd = buf;
if (cmd->comp)
- complete_all(cmd->comp);
+ complete(cmd->comp);
}
static void virtscsi_ctrl_done(struct virtqueue *vq)
OpenPOWER on IntegriCloud