summaryrefslogtreecommitdiffstats
path: root/drivers/net/ibm_newemac
diff options
context:
space:
mode:
authorRussell King <rmk+kernel@arm.linux.org.uk>2009-09-27 21:04:48 +0100
committerRussell King <rmk+kernel@arm.linux.org.uk>2009-09-28 18:06:21 +0100
commit90140c30a7b8c77e8872a389d48678d78e58789f (patch)
treeddb78c7811e89b750a7cbd364e1edcfca1981b26 /drivers/net/ibm_newemac
parente616c591405c168f6dc3dfd1221e105adfe49b8d (diff)
downloadtalos-obmc-linux-90140c30a7b8c77e8872a389d48678d78e58789f.tar.gz
talos-obmc-linux-90140c30a7b8c77e8872a389d48678d78e58789f.zip
ARM: Fix __cpuexit section mismatch warnings
Fix: WARNING: vmlinux.o(.text+0x247c): Section mismatch in reference from the function cpu_idle() to the function .cpuexit.text:cpu_die() The function cpu_idle() references a function in an exit section. Often the function cpu_die() has valid usage outside the exit section and the fix is to remove the __cpuexit annotation of cpu_die. WARNING: vmlinux.o(.cpuexit.text+0x3c): Section mismatch in reference from the function cpu_die() to the function .cpuinit.text:secondary_start_kernel() The function __cpuexit cpu_die() references a function __cpuinit secondary_start_kernel(). This is often seen when error handling in the exit function uses functionality in the init path. The fix is often to remove the __cpuinit annotation of secondary_start_kernel() so it may be used outside an init section. Sam says: > The annotation of cpu_die() is wrong. > To be annotated __cpuexit the function shall: > - be used in exit context and only in exit context with HOTPLUG_CPU=n > - be used outside exit context with HOTPLUG_CPU=y So, this also means __cpu_disable(), __cpu_die() and twd_timer_stop() are also wrong. However, removing __cpuexit from cpu_die() creates: WARNING: vmlinux.o(.text+0x6834): Section mismatch in reference from the function cpu_die() to the function .cpuinit.text:secondary_start_kernel() The function cpu_die() references the function __cpuinit secondary_start_kernel(). This is often because cpu_die lacks a __cpuinit annotation or the annotation of secondary_start_kernel is wrong. so fix this using __ref. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Diffstat (limited to 'drivers/net/ibm_newemac')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud