diff options
| author | Ivan Vecera <ivecera@redhat.com> | 2015-10-15 21:28:52 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-10-16 00:24:10 -0700 |
| commit | 47ea0325337b166c1c8695119aa6e83cdc035ef5 (patch) | |
| tree | 98d31ead764ef2c3b71843fd8926f90115a690a6 /drivers/net/ethernet/aeroflex | |
| parent | ae23051820461bdc960b76d766e7c1e92dee2ee1 (diff) | |
| download | talos-obmc-linux-47ea0325337b166c1c8695119aa6e83cdc035ef5.tar.gz talos-obmc-linux-47ea0325337b166c1c8695119aa6e83cdc035ef5.zip | |
drivers/net: get rid of unnecessary initializations in .get_drvinfo()
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().
v2: removed unused variable
v3: removed another unused variable
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/aeroflex')
| -rw-r--r-- | drivers/net/ethernet/aeroflex/greth.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/aeroflex/greth.c b/drivers/net/ethernet/aeroflex/greth.c index ae89de7deb13..20bf55dbd76f 100644 --- a/drivers/net/ethernet/aeroflex/greth.c +++ b/drivers/net/ethernet/aeroflex/greth.c @@ -1141,8 +1141,6 @@ static void greth_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *in strlcpy(info->version, "revision: 1.0", sizeof(info->version)); strlcpy(info->bus_info, greth->dev->bus->name, sizeof(info->bus_info)); strlcpy(info->fw_version, "N/A", sizeof(info->fw_version)); - info->eedump_len = 0; - info->regdump_len = sizeof(struct greth_regs); } static void greth_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *p) |
