diff options
| author | NeilBrown <neilb@suse.de> | 2014-05-28 13:39:23 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2014-05-29 16:59:47 +1000 |
| commit | f2e06c58841b3e89eaacfa88ce14389d311c54a8 (patch) | |
| tree | 34ca8dd597489694c289d0da7a007b14adbe3be1 /drivers/md | |
| parent | cf170f3fa451350e431314e1a0a52014fda4b2d6 (diff) | |
| download | talos-obmc-linux-f2e06c58841b3e89eaacfa88ce14389d311c54a8.tar.gz talos-obmc-linux-f2e06c58841b3e89eaacfa88ce14389d311c54a8.zip | |
md/bitmap: remove confusing code from filemap_get_page.
file_page_index(store, 0) is *always* 0.
This is because the bitmap sb, at 256 bytes, is *always* less than
one page.
So subtracting it has no effect and the code should be removed.
Reported-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/bitmap.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 9a8e66ae04f5..67f8b31e2054 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -669,17 +669,13 @@ static inline unsigned long file_page_offset(struct bitmap_storage *store, /* * return a pointer to the page in the filemap that contains the given bit * - * this lookup is complicated by the fact that the bitmap sb might be exactly - * 1 page (e.g., x86) or less than 1 page -- so the bitmap might start on page - * 0 or page 1 */ static inline struct page *filemap_get_page(struct bitmap_storage *store, unsigned long chunk) { if (file_page_index(store, chunk) >= store->file_pages) return NULL; - return store->filemap[file_page_index(store, chunk) - - file_page_index(store, 0)]; + return store->filemap[file_page_index(store, chunk)]; } static int bitmap_storage_alloc(struct bitmap_storage *store, |
