summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2018-10-04 17:41:37 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2018-10-04 17:42:26 -0700
commitf74c371fe72a4f820d287db8067683fb533e4ede (patch)
treef33df632923f8e573967ea1e68106bc74a29f55c /drivers/input
parent684bec1092b6991ff2a7751e8a763898576eb5c2 (diff)
downloadtalos-obmc-linux-f74c371fe72a4f820d287db8067683fb533e4ede.tar.gz
talos-obmc-linux-f74c371fe72a4f820d287db8067683fb533e4ede.zip
Input: mousedev - add a schedule point in mousedev_write()
syzbot was able to trigger rcu stalls by calling write() with large number of bytes. Add a cond_resched() in the loop to avoid this. Link: https://lkml.org/lkml/2018/8/23/1106 Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot+9436b02171ac0894d33e@syzkaller.appspotmail.com Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/mousedev.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c
index e08228061bcd..412fa71245af 100644
--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -707,6 +707,7 @@ static ssize_t mousedev_write(struct file *file, const char __user *buffer,
mousedev_generate_response(client, c);
spin_unlock_irq(&client->packet_lock);
+ cond_resched();
}
kill_fasync(&client->fasync, SIGIO, POLL_IN);
OpenPOWER on IntegriCloud