diff options
author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-04-11 15:32:48 +0800 |
---|---|---|
committer | Jason Gunthorpe <jgg@mellanox.com> | 2018-04-17 19:57:11 -0600 |
commit | f9af8730143a0fdc572f90b8a388795ee812cd74 (patch) | |
tree | 32e818461d20ca9a9f8920195f6127222d24a9af /drivers/infiniband/hw/i40iw/i40iw_main.c | |
parent | 39e487faaf706fa94bab4d0cf9f543a3430c746e (diff) | |
download | talos-obmc-linux-f9af8730143a0fdc572f90b8a388795ee812cd74.tar.gz talos-obmc-linux-f9af8730143a0fdc572f90b8a388795ee812cd74.zip |
infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_make_listen_node
i40iw_make_listen_node() is never called in atomic context.
i40iw_make_listen_node() is only called by i40iw_create_listen, which is
set as ".create_listen" in struct iw_cm_verbs.
Despite never getting called from atomic context,
i40iw_make_listen_node() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/hw/i40iw/i40iw_main.c')
0 files changed, 0 insertions, 0 deletions