summaryrefslogtreecommitdiffstats
path: root/drivers/iio/temperature/maxim_thermocouple.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-10-25 17:55:04 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-11-13 10:08:32 +0100
commitd70674eeaa5efdefb99928691161578ae0a80316 (patch)
tree7a89a59446a40d720a83a77b4dd92f1fd081bc44 /drivers/iio/temperature/maxim_thermocouple.c
parent68fae2f3df455f53d0dfe33483a49020b3b758f3 (diff)
downloadtalos-obmc-linux-d70674eeaa5efdefb99928691161578ae0a80316.tar.gz
talos-obmc-linux-d70674eeaa5efdefb99928691161578ae0a80316.zip
iio: maxim_thermocouple: detect invalid storage size in read()
As found by gcc -Wmaybe-uninitialized, having a storage_bytes value other than 2 or 4 will result in undefined behavior: drivers/iio/temperature/maxim_thermocouple.c: In function 'maxim_thermocouple_read': drivers/iio/temperature/maxim_thermocouple.c:141:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] This probably cannot happen, but returning -EINVAL here is appropriate and makes gcc happy and the code more robust. Fixes: 231147ee77f3 ("iio: maxim_thermocouple: Align 16 bit big endian value of raw reads") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org> (cherry picked from commit 32cb7d27e65df9daa7cee8f1fdf7b259f214bee2) Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/iio/temperature/maxim_thermocouple.c')
-rw-r--r--drivers/iio/temperature/maxim_thermocouple.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
index 066161a4bccd..f962f31a5eb2 100644
--- a/drivers/iio/temperature/maxim_thermocouple.c
+++ b/drivers/iio/temperature/maxim_thermocouple.c
@@ -136,6 +136,8 @@ static int maxim_thermocouple_read(struct maxim_thermocouple_data *data,
ret = spi_read(data->spi, (void *)&buf32, storage_bytes);
*val = be32_to_cpu(buf32);
break;
+ default:
+ ret = -EINVAL;
}
if (ret)
OpenPOWER on IntegriCloud