summaryrefslogtreecommitdiffstats
path: root/drivers/dma
diff options
context:
space:
mode:
authorAsias He <asias@redhat.com>2012-05-25 10:34:48 +0800
committerRusty Russell <rusty@rustcorp.com.au>2012-07-30 13:30:51 +0930
commit483001c765af6892b3fc3726576cb42f17d1d6b5 (patch)
tree7b600bf8759b51bc1d03c28f5ef92f99041d88b5 /drivers/dma
parent02e2b124943648fba0a2ccee5c3656a5653e0151 (diff)
downloadtalos-obmc-linux-483001c765af6892b3fc3726576cb42f17d1d6b5.tar.gz
talos-obmc-linux-483001c765af6892b3fc3726576cb42f17d1d6b5.zip
virtio-blk: Reset device after blk_cleanup_queue()
blk_cleanup_queue() will call blk_drian_queue() to drain all the requests before queue DEAD marking. If we reset the device before blk_cleanup_queue() the drain would fail. 1) if the queue is stopped in do_virtblk_request() because device is full, the q->request_fn() will not be called. blk_drain_queue() { while(true) { ... if (!list_empty(&q->queue_head)) __blk_run_queue(q) { if (queue is not stoped) q->request_fn() } ... } } Do no reset the device before blk_cleanup_queue() gives the chance to start the queue in interrupt handler blk_done(). 2) In commit b79d866c8b7014a51f611a64c40546109beaf24a, We abort requests dispatched to driver before blk_cleanup_queue(). There is a race if requests are dispatched to driver after the abort and before the queue DEAD mark. To fix this, instead of aborting the requests explicitly, we can just reset the device after after blk_cleanup_queue so that the device can complete all the requests before queue DEAD marking in the drain process. Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: virtualization@lists.linux-foundation.org Cc: kvm@vger.kernel.org Cc: stable@kernel.org Signed-off-by: Asias He <asias@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/dma')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud