summaryrefslogtreecommitdiffstats
path: root/arch/x86
diff options
context:
space:
mode:
authorPaul Gortmaker <paul.gortmaker@windriver.com>2015-05-01 20:05:49 -0400
committerPaul Gortmaker <paul.gortmaker@windriver.com>2015-06-16 14:12:29 -0400
commit4711e2f9caedaa07e7cdcb5e058a18762d6be9b1 (patch)
treedc1f413d6131ab74c90c13972ef99c4750e3c6dd /arch/x86
parent0f57d86787d8b1076ea8f9cbdddda2a46d534a27 (diff)
downloadtalos-obmc-linux-4711e2f9caedaa07e7cdcb5e058a18762d6be9b1.tar.gz
talos-obmc-linux-4711e2f9caedaa07e7cdcb5e058a18762d6be9b1.zip
x86: don't use module_init in non-modular intel_mid_vrtc.c
The X86_INTEL_MID option is bool, and hence this code is either present or absent. It will never be modular, so using module_init as an alias for __initcall is rather misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of device_initcall directly in this change means that the runtime impact is zero -- it will remain at level 6 in initcall ordering. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: x86@kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'arch/x86')
-rw-r--r--arch/x86/platform/intel-mid/intel_mid_vrtc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/x86/platform/intel-mid/intel_mid_vrtc.c b/arch/x86/platform/intel-mid/intel_mid_vrtc.c
index 32947ba0f62d..ee40fcb6e54d 100644
--- a/arch/x86/platform/intel-mid/intel_mid_vrtc.c
+++ b/arch/x86/platform/intel-mid/intel_mid_vrtc.c
@@ -173,5 +173,4 @@ static int __init intel_mid_device_create(void)
return platform_device_register(&vrtc_device);
}
-
-module_init(intel_mid_device_create);
+device_initcall(intel_mid_device_create);
OpenPOWER on IntegriCloud