diff options
| author | Michael Ellerman <mpe@ellerman.id.au> | 2018-11-27 19:16:44 +1100 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2018-12-22 21:04:22 +1100 |
| commit | 47918bc68b7427e961035949cc1501a864578a69 (patch) | |
| tree | 85879293d68d72cd4215795179c0e471b8623072 /arch/powerpc/platforms | |
| parent | 7f92891778dff62303c070ac81de7b7d80de331a (diff) | |
| download | talos-obmc-linux-47918bc68b7427e961035949cc1501a864578a69.tar.gz talos-obmc-linux-47918bc68b7427e961035949cc1501a864578a69.zip | |
powerpc/pseries: Fix node leak in update_lmb_associativity_index()
In update_lmb_associativity_index() we lookup dr_node using
of_find_node_by_path() which takes a reference for us. In the
non-error case we forget to drop the reference. Note that
find_aa_index() does modify properties of the node, but doesn't need
an extra reference held once it's returned.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/platforms')
| -rw-r--r-- | arch/powerpc/platforms/pseries/hotplug-memory.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c index be8a6db3558e..d291b618a559 100644 --- a/arch/powerpc/platforms/pseries/hotplug-memory.c +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c @@ -197,6 +197,7 @@ static int update_lmb_associativity_index(struct drmem_lmb *lmb) found = find_aa_index(dr_node, ala_prop, lmb_assoc, &aa_index); + of_node_put(dr_node); dlpar_free_cc_nodes(lmb_node); if (!found) { |
